Reorder priority for conflicting datasets#142
Merged
Teque5 merged 2 commits intosigmf:mainfrom Mar 20, 2026
Merged
Conversation
Collaborator
|
Issue Makes sense to me - especially since it's called out in the spec. I added a related test. Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our team is running into an edge case where we have datasets that contain conflicting non-conforming dataset (NCD) and sigmf compliant data files. For example, we have filename.sigmf-meta, filename.cdif, and filename.sigmf-data, where the sigmf-meta has core:dataset set to filename.cdif. Currently, if we use fromfile to read in filename.sigmf-meta, it will pair the meta file with the sigmf-data file rather than the cdif. Given the SigMF spec, we would expect that if core:dataset is set, that means we have a NCD (even if a sigmf-data file with a matching filename exists), thus the file specified by core:dataset should be prioritized over the sigmf-data file.
From the spec:
The full filename of the Dataset file this Metadata file describes, used ONLY with Non-Conforming Datasets
If a Recording does not have this field, it MUST have a compliant SigMF Dataset (NOT a Non-Conforming Dataset) which MUST use the same base filename as the Metadata file and use the .sigmf-data extension